Skip to content

Feat: Adds Nile Jackson's .java files for lesson16 #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

nilejack
Copy link
Contributor

@nilejack nilejack commented Nov 1, 2024

All files in this PR are a work in progress, I will submit corrections, in full, by Monday.

@nilejack nilejack closed this Nov 3, 2024
@nilejack nilejack deleted the NileJacksonLesson16 branch November 3, 2024 14:08
@nilejack nilejack restored the NileJacksonLesson16 branch November 4, 2024 13:03
@nilejack nilejack reopened this Nov 4, 2024
Copy link

@VicenteVigueras VicenteVigueras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, there's some things I want you to review, let's start with these:

  • Some files are duplicated, please organize them. You should have one file for your implementation and another for your tests. 2 files total.
  • Ensure that your directories are correctly formatted. All folder names should be in lowercase, without spaces or symbols.

If you need help, don't hesitate to reach out.

Copy link
Contributor

@anthonydmays anthonydmays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss your work on this. I sense you have questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants